package dept import ( "context" "errors" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" "go.uber.org/mock/gomock" "perms-system-server/internal/consts" "perms-system-server/internal/loaders" "perms-system-server/internal/middleware" deptModel "perms-system-server/internal/model/dept" "perms-system-server/internal/response" "perms-system-server/internal/svc" "perms-system-server/internal/testutil" "perms-system-server/internal/testutil/ctxhelper" "perms-system-server/internal/testutil/mocks" "perms-system-server/internal/types" "testing" ) func TestUpdateDept_Normal(t *testing.T) { ctx := ctxhelper.SuperAdminCtx() svcCtx := svc.NewServiceContext(testutil.GetTestConfig()) conn := testutil.GetTestSqlConn() deptId, err := insertDeptRaw(ctx, svcCtx, 0, "upd_"+testutil.UniqueId(), "/") require.NoError(t, err) t.Cleanup(func() { testutil.CleanTable(ctx, conn, "`sys_dept`", deptId) }) newName := "updated_" + testutil.UniqueId() l := NewUpdateDeptLogic(ctx, svcCtx) err = l.UpdateDept(&types.UpdateDeptReq{ Id: deptId, Name: newName, Sort: 99, Remark: "updated remark", Status: 2, }) require.NoError(t, err) d, err := svcCtx.SysDeptModel.FindOne(ctx, deptId) require.NoError(t, err) assert.Equal(t, newName, d.Name) assert.Equal(t, int64(99), d.Sort) assert.Equal(t, "updated remark", d.Remark) assert.Equal(t, int64(2), d.Status) } // TC-0102: 不存在 func TestUpdateDept_NotFound(t *testing.T) { ctx := ctxhelper.SuperAdminCtx() svcCtx := svc.NewServiceContext(testutil.GetTestConfig()) l := NewUpdateDeptLogic(ctx, svcCtx) err := l.UpdateDept(&types.UpdateDeptReq{ Id: 999999999, Name: "ghost_" + testutil.UniqueId(), }) require.Error(t, err) var ce *response.CodeError require.True(t, errors.As(err, &ce)) assert.Equal(t, 404, ce.Code()) assert.Equal(t, "部门不存在", ce.Error()) } // TC-0101: 正常更新 func TestUpdateDept_StatusZeroUnchanged(t *testing.T) { ctx := ctxhelper.SuperAdminCtx() svcCtx := svc.NewServiceContext(testutil.GetTestConfig()) conn := testutil.GetTestSqlConn() deptId, err := insertDeptRaw(ctx, svcCtx, 0, "s0_"+testutil.UniqueId(), "/") require.NoError(t, err) t.Cleanup(func() { testutil.CleanTable(ctx, conn, "`sys_dept`", deptId) }) before, err := svcCtx.SysDeptModel.FindOne(ctx, deptId) require.NoError(t, err) assert.Equal(t, int64(1), before.Status) l := NewUpdateDeptLogic(ctx, svcCtx) err = l.UpdateDept(&types.UpdateDeptReq{ Id: deptId, Name: "changed_" + testutil.UniqueId(), Status: 0, }) require.NoError(t, err) after, err := svcCtx.SysDeptModel.FindOne(ctx, deptId) require.NoError(t, err) assert.Equal(t, int64(1), after.Status) } // TC-0103: DeptType NORMAL→DEV func TestUpdateDept_DeptType_NormalToDev(t *testing.T) { ctx := ctxhelper.SuperAdminCtx() svcCtx := svc.NewServiceContext(testutil.GetTestConfig()) conn := testutil.GetTestSqlConn() deptId, err := insertDeptRaw(ctx, svcCtx, 0, "dt_"+testutil.UniqueId(), "/") require.NoError(t, err) t.Cleanup(func() { testutil.CleanTable(ctx, conn, "`sys_dept`", deptId) }) before, err := svcCtx.SysDeptModel.FindOne(ctx, deptId) require.NoError(t, err) assert.Equal(t, "NORMAL", before.DeptType) l := NewUpdateDeptLogic(ctx, svcCtx) err = l.UpdateDept(&types.UpdateDeptReq{ Id: deptId, Name: "dt_changed_" + testutil.UniqueId(), DeptType: "DEV", }) require.NoError(t, err) after, err := svcCtx.SysDeptModel.FindOne(ctx, deptId) require.NoError(t, err) assert.Equal(t, "DEV", after.DeptType) } // TC-0104: DeptType无效值返回错误 func TestUpdateDept_DeptType_InvalidRejected(t *testing.T) { ctx := ctxhelper.SuperAdminCtx() svcCtx := svc.NewServiceContext(testutil.GetTestConfig()) conn := testutil.GetTestSqlConn() deptId, err := insertDeptRaw(ctx, svcCtx, 0, "dti_"+testutil.UniqueId(), "/") require.NoError(t, err) t.Cleanup(func() { testutil.CleanTable(ctx, conn, "`sys_dept`", deptId) }) l := NewUpdateDeptLogic(ctx, svcCtx) err = l.UpdateDept(&types.UpdateDeptReq{ Id: deptId, Name: "dti_changed_" + testutil.UniqueId(), DeptType: "INVALID_TYPE", }) require.Error(t, err) var ce *response.CodeError require.True(t, errors.As(err, &ce)) assert.Equal(t, 400, ce.Code()) assert.Contains(t, ce.Error(), "部门类型无效") after, err := svcCtx.SysDeptModel.FindOne(ctx, deptId) require.NoError(t, err) assert.Equal(t, "NORMAL", after.DeptType, "无效DeptType不应修改数据库") } // TC-0533: updateDept非超管拒绝 func TestUpdateDept_NonSuperAdminRejected(t *testing.T) { ctx := ctxhelper.AdminCtx("test_product") svcCtx := svc.NewServiceContext(testutil.GetTestConfig()) l := NewUpdateDeptLogic(ctx, svcCtx) err := l.UpdateDept(&types.UpdateDeptReq{Id: 1, Name: "test"}) require.Error(t, err) var ce *response.CodeError require.True(t, errors.As(err, &ce)) assert.Equal(t, 403, ce.Code()) } func superAdminCtx() context.Context { return middleware.WithUserDetails(context.Background(), &loaders.UserDetails{ UserId: 1, Username: "su", IsSuperAdmin: true, MemberType: consts.MemberTypeSuperAdmin, Status: consts.StatusEnabled, }) } // TC-0848: deptType 变更 → FindIdsByDeptId 恰好调用 1 次,返回 [100, 101];handler 返回 nil。 func TestUpdateDept_DeptTypeChanged_InvokesFindIdsOnce(t *testing.T) { ctrl := gomock.NewController(t) t.Cleanup(ctrl.Finish) deptMock := mocks.NewMockSysDeptModel(ctrl) userMock := mocks.NewMockSysUserModel(ctrl) // 老部门是 NORMAL,请求改成 DEV → deptTypeChanged=true 才能触发 FindIdsByDeptId。 deptMock.EXPECT().FindOne(gomock.Any(), int64(77)). Return(&deptModel.SysDept{ Id: 77, Name: "n", DeptType: consts.DeptTypeNormal, Status: consts.StatusEnabled, UpdateTime: 500, }, nil) deptMock.EXPECT().UpdateWithOptLock(gomock.Any(), gomock.Any(), int64(500)).Return(nil) // 关键断言:恰好调用 1 次;返回的切片会被继续塞进 CleanByUserIds(loader 内部走 Redis)。 userMock.EXPECT().FindIdsByDeptId(gomock.Any(), int64(77)). Return([]int64{100, 101}, nil).Times(1) svcCtx := mocks.NewMockServiceContext(mocks.MockModels{ Dept: deptMock, User: userMock, }) err := NewUpdateDeptLogic(superAdminCtx(), svcCtx).UpdateDept(&types.UpdateDeptReq{ Id: 77, Name: "n", Sort: 0, Remark: "", DeptType: consts.DeptTypeDev, }) require.NoError(t, err, "正常场景 UpdateDept 必须返回 nil,且仅调用一次 FindIdsByDeptId") } // TC-0849: FindIdsByDeptId 返回 err —— handler 仍返回 nil(degraded 成功),旧缓存由 TTL 过期兜底。 func TestUpdateDept_FindIdsByDeptIdError_DegradedSuccess(t *testing.T) { ctrl := gomock.NewController(t) t.Cleanup(ctrl.Finish) deptMock := mocks.NewMockSysDeptModel(ctrl) userMock := mocks.NewMockSysUserModel(ctrl) deptMock.EXPECT().FindOne(gomock.Any(), int64(88)). Return(&deptModel.SysDept{ Id: 88, Name: "n", DeptType: consts.DeptTypeNormal, Status: consts.StatusEnabled, UpdateTime: 1000, }, nil) deptMock.EXPECT().UpdateWithOptLock(gomock.Any(), gomock.Any(), int64(1000)).Return(nil) userMock.EXPECT().FindIdsByDeptId(gomock.Any(), int64(88)). Return(nil, errors.New("transient DB error")) svcCtx := mocks.NewMockServiceContext(mocks.MockModels{ Dept: deptMock, User: userMock, }) err := NewUpdateDeptLogic(superAdminCtx(), svcCtx).UpdateDept(&types.UpdateDeptReq{ Id: 88, Name: "n", DeptType: consts.DeptTypeDev, }) assert.NoError(t, err, "FindIdsByDeptId 失败不得映射 500;TTL 过期兜底,客户端不应重试整次 UpdateDept") } // 补充:deptType / status 都没变时,不应调 FindIdsByDeptId(避免无效缓存失效风暴)。 func TestUpdateDept_NoEffectiveChange_SkipsFindIds(t *testing.T) { ctrl := gomock.NewController(t) t.Cleanup(ctrl.Finish) deptMock := mocks.NewMockSysDeptModel(ctrl) userMock := mocks.NewMockSysUserModel(ctrl) // 老部门 DEV,请求也是 DEV;status 未传 → 没有变更。 deptMock.EXPECT().FindOne(gomock.Any(), int64(99)). Return(&deptModel.SysDept{ Id: 99, Name: "x", DeptType: consts.DeptTypeDev, Status: consts.StatusEnabled, UpdateTime: 200, }, nil) deptMock.EXPECT().UpdateWithOptLock(gomock.Any(), gomock.Any(), int64(200)).Return(nil) // 关键:没有任何 FindIdsByDeptId EXPECT 即等价 Times(0)。 svcCtx := mocks.NewMockServiceContext(mocks.MockModels{ Dept: deptMock, User: userMock, }) err := NewUpdateDeptLogic(superAdminCtx(), svcCtx).UpdateDept(&types.UpdateDeptReq{ Id: 99, Name: "x", DeptType: consts.DeptTypeDev, Sort: 1, }) require.NoError(t, err, "无变更时 UpdateDept 只做元字段更新,不得触发缓存清理风暴") }